Skip to content

fix: Show incomplete indicator only if completion list is not empty #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenporras merged 1 commit into from
Dec 15, 2025
Merged

fix: Show incomplete indicator only if completion list is not empty #1471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions org.eclipse.lsp4e.test/src/org/eclipse/lsp4e/test/completion/IncompleteCompletionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,4 +675,21 @@ public void testIncompleteIndication() throws CoreException {
assertEquals("FirstClass", proposalsWithIncompleteProposal[0].getDisplayString());
assertEquals("➕ Continue typing for more proposals...", proposalsWithIncompleteProposal[1].getDisplayString());
}

@Test
public void testIncompleteIndicationWithEmptyList() throws CoreException {
MockLanguageServer.INSTANCE.setCompletionList(new CompletionList(true, List.of()));

IFile testFile = TestUtils.createUniqueTestFile(project, "");
ITextViewer viewer = TestUtils.openTextViewer(testFile);

// without incomplete indication
ICompletionProposal[] proposals = contentAssistProcessor.computeCompletionProposals(viewer, 0);
assertEquals(0, proposals.length);

// with incomplete indication
final var incompleIndicatingProcessor = new LSContentAssistProcessor(true, true);
ICompletionProposal[] proposalsWithIncompleteProposal = incompleIndicatingProcessor.computeCompletionProposals(viewer, 0);
assertEquals(0, proposalsWithIncompleteProposal.length);
}
}
5 changes: 4 additions & 1 deletion org.eclipse.lsp4e/src/org/eclipse/lsp4e/operations/completion/LSContentAssistProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,10 @@ public ICompletionProposal[] computeCompletionProposals(ITextViewer viewer, int
}
completeProposals.sort(proposalComparator);
final ICompletionProposal incompleteProposal = createIncompleteProposal(offset, anyIncomplete.get());
if (incompleteProposal != null) {
if (incompleteProposal != null && !completeProposals.isEmpty()) {
// Only add the incompleteProposal if the list is not empty.
// Otherwise we might get a completion popup which contains only the incompleteProposal.

@SuppressWarnings("unchecked")
final var incompleteProposals = (List<ICompletionProposal>) (List<?>) completeProposals;
incompleteProposals.add(incompleteProposal);
Expand Down