Enable required extended capabilities when loading project #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I threw in a GitHub Action to test that the changes work. I expect at least 1 failure, since the link in the Bulkhead docs is hardcoded to the Jenkins maven repo path |
Contributor
Author
|
It seems the diagnostic tests are still flakey. I think we need to make a decision if we are okay with testing the Bulkhead link knowing it will only work properly on Jenkins, or if we want to disable the extended capability for that test run and pretend the link doesn't exist. |
Fixes eclipse-lsp4mp#450 Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
450-bulkhead-docs-not-resolving
branch
from
5381b80 to
5eb8ce0
Compare
Contributor
Author
|
See #487 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #450
TODO per-merge: