Support for value validation with Enum in Safe mode #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
force-pushed
the
enum_support_in_safe_mode
branch
6 times, most recently
from
46a1ca7 to
60de440
Compare
Signed-off-by: azerr <[email protected]>
angelozerr
force-pushed
the
enum_support_in_safe_mode
branch
from
60de440 to
78a7be5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Enum Value Validation in Safe Mode
In safe mode, the
Enumclass cannot be loaded, which prevents proper validation of enum values.However, enumeration constant names can still be retrieved from JDT, IntelliJ, and properties files (via
HintValue).This PR introduces built-in validation in the enum converter by using the available enumeration constant names.
Here the result in safe mode (the enum class is not loaded from classpath and in this case converter uses values retrieved from JDT):