Use diagnostics from the context #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: azerr <[email protected]>
angelozerr
force-pushed
the
refact_diag_context
branch
from
95d942e to
e4c692c
Compare
Contributor
Author
|
@datho7561 please review this PR. I know it will break the current API but I have not seen some code instead in LSP4MP which implements this API. @turkeylurkey and your team please tell me if you are OK with this change. I have done this similar changes in IJ Quarkus. |
datho7561
approved these changes
Nov 25, 2025
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
This change makes a lot of sense and cleans up the code. Thanks, Angelo!
Contributor
Author
Thanks @datho7561! |
Contributor
|
This change is ok for us too. |
Contributor
Author
Thanks @turkeylurkey for your reply. I merge the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a design error when diagnostics must be collected. The IJavaDiagnosticsParticipant defines a method like:
List<Diagnostic> collectDiagnostics(JavaDiagnosticsContext context, IProgressMonitor monitor) throws CoreException;which returns a list of diagnostics for the given context (a given file uri)
The collectDiagnostics should not return a list of diagnostics and should use
JavaDiagnosticsContext #addDiagnosticThis PR fixes that and fixes also the file uri which is used when diagnostic is created although diagnostic doesn't store some uri.