Skip to content

Derive Test JRE from configuration of maven-enforcer-plugin - #2070

Merged
kwin merged 3 commits into
mainfrom
feature/maven-execution-jre-for-tests
Nov 12, 2025
Merged

Derive Test JRE from configuration of maven-enforcer-plugin#2070
kwin merged 3 commits into
mainfrom
feature/maven-execution-jre-for-tests

Conversation

@kwin

@kwin kwin commented Oct 20, 2025

Copy link
Copy Markdown
Member

Similar to what is done for the Maven Launch Configurations. Move logic for Maven Execution JRE to org.eclipse.m2e.jdt.

This closes #2059

@kwin
kwin force-pushed the feature/maven-execution-jre-for-tests branch from ae35520 to 2c8b9be Compare October 20, 2025 16:30
@eclipse-m2e-bot

eclipse-m2e-bot commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

org.eclipse.m2e.feature/feature.xml
org.eclipse.m2e.sdk.feature/feature.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 769fe460fa47b384ffa64996bffea5234477a007 Mon Sep 17 00:00:00 2001
From: Eclipse M2E Bot <m2e-bot@eclipse.org>
Date: Tue, 21 Oct 2025 08:42:20 +0000
Subject: [PATCH] Version bump(s) for null object or invalid expression stream


diff --git a/org.eclipse.m2e.feature/feature.xml b/org.eclipse.m2e.feature/feature.xml
index e153e1f1..b637f8d3 100644
--- a/org.eclipse.m2e.feature/feature.xml
+++ b/org.eclipse.m2e.feature/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.m2e.feature"
       label="%featureName"
-      version="2.9.200.qualifier"
+      version="2.10.0.qualifier"
       provider-name="%providerName"
       plugin="org.eclipse.m2e.core"
       license-feature="org.eclipse.license"
diff --git a/org.eclipse.m2e.sdk.feature/feature.xml b/org.eclipse.m2e.sdk.feature/feature.xml
index 97dca0c3..a19f245c 100644
--- a/org.eclipse.m2e.sdk.feature/feature.xml
+++ b/org.eclipse.m2e.sdk.feature/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.m2e.sdk.feature"
       label="%featureName"
-      version="2.9.200.qualifier"
+      version="2.10.0.qualifier"
       provider-name="%providerName"
       license-feature="org.eclipse.license"
       license-feature-version="0.0.0">
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions

github-actions Bot commented Oct 20, 2025

Copy link
Copy Markdown

Test Results

  327 files  +3    327 suites  +3   1h 4m 45s ⏱️ - 13m 16s
  692 tests ±0    670 ✅ +2  21 💤 ±0  0 ❌  - 2  1 🔥 ±0 
2 076 runs  ±0  2 012 ✅ +2  63 💤 ±0  0 ❌  - 2  1 🔥 ±0 

For more details on these errors, see this check.

Results for commit a3f92b0. ± Comparison against base commit 8a315af.

This pull request removes 5 and adds 5 tests. Note that renamed tests count towards both.
org.eclipse.m2e.internal.launch.MavenLaunchDelegateTest ‑ testGetBestMatchingVM_1XversionRange
org.eclipse.m2e.internal.launch.MavenLaunchDelegateTest ‑ testGetBestMatchingVM_9versionRange
org.eclipse.m2e.internal.launch.MavenLaunchDelegateTest ‑ testGetBestMatchingVM_majorOnly
org.eclipse.m2e.internal.launch.MavenLaunchDelegateTest ‑ testGetBestMatchingVM_rangeWithOnlyMajorLowerBound
org.eclipse.m2e.internal.launch.MavenLaunchDelegateTest ‑ testGetBestMatchingVM_versionRangeWithNoMajorVersionMatch
org.eclipse.m2e.jdt.tests.MavenExecutionJreTest ‑ testGetBestMatchingVM_1XversionRange
org.eclipse.m2e.jdt.tests.MavenExecutionJreTest ‑ testGetBestMatchingVM_9versionRange
org.eclipse.m2e.jdt.tests.MavenExecutionJreTest ‑ testGetBestMatchingVM_majorOnly
org.eclipse.m2e.jdt.tests.MavenExecutionJreTest ‑ testGetBestMatchingVM_rangeWithOnlyMajorLowerBound
org.eclipse.m2e.jdt.tests.MavenExecutionJreTest ‑ testGetBestMatchingVM_versionRangeWithNoMajorVersionMatch

♻️ This comment has been updated with latest results.

@kwin
kwin force-pushed the feature/maven-execution-jre-for-tests branch 2 times, most recently from aad9c65 to ae10f7a Compare October 21, 2025 08:37
@kwin
kwin requested review from HannesWell and laeubi October 21, 2025 09:22
@kwin
kwin force-pushed the feature/maven-execution-jre-for-tests branch from 9d3934c to a162b17 Compare October 21, 2025 09:40
@kwin
kwin marked this pull request as ready for review October 21, 2025 09:56
@kwin

kwin commented Oct 30, 2025

Copy link
Copy Markdown
Member Author

@laeubi @HannesWell Any concerns with this?

kwin and others added 3 commits November 11, 2025 16:46
Similar to what is done for the Maven Launch Configurations.
Move logic for Maven Execution JRE to org.eclipse.m2e.jdt.

This closes #2059
Add release notes entry
@kwin
kwin force-pushed the feature/maven-execution-jre-for-tests branch from a162b17 to a3f92b0 Compare November 11, 2025 15:46
@kwin
kwin merged commit 4b69dfc into main Nov 12, 2025
8 of 11 checks passed
@kwin
kwin deleted the feature/maven-execution-jre-for-tests branch November 12, 2025 13:42
@HannesWell HannesWell added this to the 2.10.0 milestone Dec 3, 2025
@subes

subes commented Feb 12, 2026

Copy link
Copy Markdown

Please add an option in eclipse to opt out of this feature: #2137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UnitTestSupport should set JRE to Maven Execution JRE (same as Maven Launches)

4 participants