Open
Conversation
ralight
force-pushed
the
develop
branch
2 times, most recently
from
6b404a7 to
2c4967a
Compare
On Windows, CUnit.h defines snprintf as a macro. This causes stdio.h to abort with an error. Including stdio.h first should fix this. Long term, this needs CUnit to be fixed or we stop using it.
This doesn't mean the tests work, but everything compiles.
This avoids the problem that subprocess.PIPE is limited in size on Windows and cannot be extended
ralight
force-pushed
the
windows-testing
branch
from
31deb60 to
3ddfdc3
Compare
ralight
force-pushed
the
develop
branch
5 times, most recently
from
3eefaac to
2067537
Compare
ralight
force-pushed
the
develop
branch
7 times, most recently
from
74cc684 to
fd0fa72
Compare
ralight
force-pushed
the
develop
branch
3 times, most recently
from
f8278c0 to
348f2ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing your time to the Mosquitto project!
Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.
Then please check the following list of things we ask for in your pull request:
make testwith your changes locally?