Adding new means for brigde authentication.#3436
Adding new means for brigde authentication.#3436ThorstenWendt-TP wants to merge 1 commit intoeclipse-mosquitto:developfrom
Conversation
|
@ThorstenWendt-TP I like the ldea of this! Thank you for including tests and documentation as well, that's very refreshing. Could you please check that you used the same email address to sign the Eclipse ECA as you used in the commit? It's currently saying you aren't covered and I can't accept a change like this without that. |
|
I'm happy you like the idea. Thank you very much. The email address is the same but I had to choose different user names (eclipse don't accept capital letters and special character ;). |
|
When I try and manually do a check it's returning an error, so perhaps the check service isn't working properly at the moment. I'll report it to Eclipse |
|
Ok, I've checked by creating a fresh account that hasn't signed the ECA and it generates the same error. I also guessed your eclipse account username and it gives the same error - so could you please recheck that the ECA is showing as signed in your account? |
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
|
You are right. I forgot to submit my Eclipse Contributor Agreement. Sorry for that |
f8278c0 to
348f2ba
Compare
8026e8f to
6927ee5
Compare
This patch introduces a new way to provide credentials for bridge authentication. Currently the only way to provide bridge authentication credentials is to set remote_username and remote_password in the configuration file. There was no other way to provide these credentials. But for example on some platforms these credentials are stored in a TPM. There is no direct way to pull these credentials from TPM and use it for bridge authentication. With this patch these credentials can be provided by a plugin that yields username/password on bridge setup and will be used for broker authentication. Customers can provide this plugin without publishing their source code. For more details see: doc/brigde-authentication-by-plugin.md Signed-off-by: Thorsten Wendt <thorsten.wendt@ebblo.com>
6927ee5 to
fec1d15
Compare
|
Our company changed it's name from Trapezegroup to ebblo, hence I updated copyrights, emails, ... |
This patch introduces a new way to provide credentials for bridge authentication.
Currently the only way to provide bridge authentication credentials is to set remote_username and remote_password in the configuration file. There was no other way to provide these credentials.
But for example on some platforms these credentials are stored in a TPM. There is no direct way to pull these credentials from TPM and use it for bridge authentication.
With this patch these credentials can be provided by a plugin that yields username/password on bridge setup and will be used for broker authentication. Customers can provide this plugin without publishing their source code.
For more details see: doc/brigde-authentication-by-plugin.md
Thank you for contributing your time to the Mosquitto project!
Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.
Then please check the following list of things we ask for in your pull request:
make testwith your changes locally?