Skip to content

Add a workflow with some features disabled#3525

Open
mattst88 wants to merge 8 commits intoeclipse-mosquitto:masterfrom
mattst88:add-reduced-workflow
Open

Add a workflow with some features disabled#3525
mattst88 wants to merge 8 commits intoeclipse-mosquitto:masterfrom
mattst88:add-reduced-workflow

Conversation

@mattst88
Copy link
Contributor

@mattst88 mattst88 commented Feb 25, 2026

Build and test with a collection of options that have in practice resulted in test failures:

WITH_EDITLINE=no
WITH_HTTP_API=no
WITH_WEBSOCKETS=no
WITH_PERSISTENCE=no
WITH_SRV=no

Thank you for contributing your time to the Mosquitto project!

Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.

Then please check the following list of things we ask for in your pull request:

  • Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • If you are contributing a new feature, is your work based off the develop branch?
  • If you are contributing a bugfix, is your work based off the fixes branch?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?

@mattst88 mattst88 force-pushed the add-reduced-workflow branch from 517f20b to 34974fb Compare February 25, 2026 02:42
@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattst88
Copy link
Contributor Author

make ptest's doesn't respect WITH_*. I'll add a few patches to fix this.

This automatically disables TLS-PSK when TLS is disabled.

Signed-off-by: Matt Turner <mattst88@gmail.com>
This automatically disables WebSockets when TLS is disabled.

Signed-off-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Matt Turner <mattst88@gmail.com>
@mattst88 mattst88 force-pushed the add-reduced-workflow branch 2 times, most recently from b8d7890 to ee9cc76 Compare February 25, 2026 14:11
Recognize an exit code of 77 as "test skipped". This is the exit code
traditionally used by autotools and meson. The next commit enables this
same support in CMake.

Unfortunately, for plain `make` we still have to exclude the tests (as
was done in the previous commit).

Signed-off-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Matt Turner <mattst88@gmail.com>
Build and test with a collection of options that have in practice
resulted in test failures:

```
WITH_EDITLINE=no
WITH_HTTP_API=no
WITH_PERSISTENCE=no
WITH_SRV=no
WITH_TLS=no
WITH_TLS_PSK=no
WITH_WEBSOCKETS=no
```

Signed-off-by: Matt Turner <mattst88@gmail.com>
@mattst88 mattst88 force-pushed the add-reduced-workflow branch from ee9cc76 to cd4736a Compare February 25, 2026 14:47
@mattst88 mattst88 mentioned this pull request Feb 25, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant