Open XL DDR Enablement initial commit #7880
Conversation
Deigue
force-pushed
the
openxl-ddr
branch
2 times, most recently
from
c0a4493 to
0afd5d0
Compare
| //newAttr->_stringdata = strndup(firstQuote + 1, secondQuote - firstQuote - 1); | ||
| //temporary placeholder to get around compilation, replace with alt implementation later. | ||
| newAttr->_stringdata = strdup(firstQuote + 1); |
There was a problem hiding this comment.
This cannot stay this way: we want just the characters between the quotes.
|
@keithc-ca @joransiu omr/ddr/tools/ddrgen/ddrgen.cpp Lines 131 to 132 in 6fcc12d omr/ddr/lib/ddr-scanner/dwarf/DwarfScanner.cpp Lines 1777 to 1789 in 6fcc12d omr/ddr/lib/ddr-scanner/dwarf/DwarfScanner.cpp Lines 1800 to 1817 in 6fcc12d omr/ddr/lib/ddr-scanner/dwarf/DwarfScanner.cpp Lines 139 to 148 in 6fcc12d omr/ddr/lib/ddr-scanner/dwarf/DwarfParser.cpp Lines 131 to 133 in 6fcc12d I've been trying to debug around these, I see from the make files that there is a executable I do see a few indicators, like: which if not matched, it will bypass entering the intended logic above. I also noticed that where Keith had suggested to add: Reviewing the references, it is only coming into play here? (But the above is unapplicable code, as it is in the Going to try to enable the debug statements so that the already existing But any suggestions or ideas, in case I am straying the wrong path? Doesn't look like it is quite reaching the |
|
Hmm, it looks like it is not even getting past into the scanner code, because of this in omr/ddr/tools/ddrgen/ddrgen.cpp Lines 131 to 132 in 6fcc12d from where is this (ddrgen.cpp) invoked? Because it looks like the options parsed from the arguments is such that the debugFiles is completely empty, so it thinks there is no work to be done and skips over everything downstream.
I tried to find the command where it gets kicked off, but I am getting confused (or only seeing .mk or old build code that may not be applicable). The I printed out the arguments being passed in to this executable being called, I was expecting the dwo file paths, but actually I got these: Reading the |
I don't see anything here that would select |
Deigue
force-pushed
the
openxl-ddr
branch
3 times, most recently
from
4f8ab1a to
7f76f1d
Compare
|
I am seeing some errors quite early in the build when trying to switch to the temporary directory -- Starting with CMake version 3.5.1
-- Found Git: /rsusr/miniconda/envs/stlaba0/bin/git (found version "2.14.4-12")
-- LIBELF_LIBRARY = /jit/team/gauravc/include/libdwarf/libelfdwarf64.x
-- Could NOT find LibElf (missing: ELF_H_INCLUDE_DIR LIBELF_H_INCLUDE_DIR)
-- LIBDWARF_LIBRARY =
-- Found LibDwarf: /jit/team/gauravc/include/libdwarf/libdwarf.a
-- Found Perl: /rsusr/miniconda/envs/stlaba0/bin/perl (found version "5.24.4")
You have called ADD_LIBRARY for library j9dyn without any source files. This typically indicates a problem with your CMakeLists.txt file
-- Creating shared library for j9jit
-- Adding PRIVATE compiler options to j9jit for j9jit.
-- Configuring incomplete, errors occurred!I tried changing the The changes I made to find The |
|
I am also able to confirm that it is successfully compiling with below command: (standalone) Just having problems having to use this include and make it to that part of the build with using the right |
Deigue
force-pushed
the
openxl-ddr
branch
6 times, most recently
from
d16fb74 to
fea9ac5
Compare
Deigue
force-pushed
the
openxl-ddr
branch
2 times, most recently
from
48b339a to
8ca4e95
Compare
Merge/rebase prior changes: - rebase eclipse/master 2025-09-17 - keep DwarfParser.cpp (debug changes, unused currently) - cleanup old dwo related changes and merge commits Signed-off-by: Gaurav Chaudhari <[email protected]>
Signed-off-by: Gaurav Chaudhari <[email protected]>
Signed-off-by: Gaurav Chaudhari <[email protected]>
Signed-off-by: Gaurav Chaudhari <[email protected]>
Signed-off-by: Gaurav Chaudhari <[email protected]>
2 participants
Initial set of stopgap changes to enable DDR to work with the Open XL beta.