Fix GC IDs for JFR #7903
Draft
Fix GC IDs for JFR #7903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmitripivkine @amicic I've added a variable in cycle state to store the ID during cycle start. |
| stats->clearPauseStats(); | ||
|
|
||
| MM_GCExtensionsBase* extensions = env->getExtensions(); | ||
| env->_cycleState->_currentCycleID = extensions->getUniqueGCCycleCount(); |
There was a problem hiding this comment.
there is _extensions exists already, there is no need to create new one
There was a problem hiding this comment.
I've changed all references to _extensions instead of a new one. The problem with the count for parallel gc persists, unfortunately.
adpopescu
force-pushed
the
jfr-gc-ids
branch
from
bce5574 to
47e9f7c
Compare
adpopescu
force-pushed
the
jfr-gc-ids
branch
from
47e9f7c to
1ae3e76
Compare
This change fixes some inconsistencies with the GC IDs. Signed-off-by: Adrian Popescu <[email protected]> Add JFR logging structures and apis for GC events This change adds all the necessary structures and apis to add some new GC JFR events. Signed-off-by: Adrian Popescu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes some inconsistencies with the GC IDs.