Add OMRPortLib to Jit test compiler environment #7912
Conversation
|
While I was working on some vector evaluators, I noticed we have some jit test to cover those but we never run it on z platform. |
|
@r30shah I want to know your expert opinion on this to see if there are any unwanted consequences or not. I also want to make sure other platforms are okay with this change since the scope of this is cross-platform! |
|
What test pipeline I can use to test this on all platforms? |
|
jenkins build all |
|
@ehsankianifar There are series of failure with the proposed change. Though I do agree having creating and using port lib for test to enable the testing of newer features through OMR tests, I think this kind of work requires an issue documenting what problem we are facing with not using port lib and how are you planning to address it - Not to mention we should not have failures so let's start with the issue so we can discuss on possible solution. |
|
jenkins build all |
1 similar comment
|
jenkins build all |
|
Instead of changing the |
|
I observed some failures on jenkins builds on IBM Z platforms and RISC_V64. The same tests that fail on zLinux pass on my local setup. @r30shah is there a way to book these jenkin machines to investigate? |
|
I think the test setup is not providing the correct arguments to the tree! We expect 32bit 'float' type but the test provides 64bit |
|
The jenkins environment is using GCC 4.8 |
You can open up issue internally to runtimes/infrastructure to get access to the machine (Tag @AdamBrousseau ) |
|
I think the problem is that |
ehsankianifar
force-pushed
the
AddOmrPortLibToJitTestEnvironment
branch
from
6e4cb0f to
fb20afe
Compare
Jit test harness initialize a OMRPortLibrary but never add it to the compiler environment. Some platforms like z rely on port library for some operations like getting the cpu features. As a result, z always defaults on the minimum supported version to get cpu features in evaluators while running compiler tests which does not match the actual cpu and cause false failures. This change add the OMRPortLibrary to the test compiler environment. signed-off-by: Ehsan Kiani Far <[email protected]>
ehsankianifar
force-pushed
the
AddOmrPortLibToJitTestEnvironment
branch
from
2bd626d to
6591ad9
Compare
|
@r30shah can I ask you to trigger the tests again? |
3 participants
Jit test harness initialize a OMRPortLibrary but never add it to the compiler environment. Some platforms like z rely on port library for some operations like getting the cpu features. As a result, z always defaults on the minimum supported version to get cpu features in evaluators while running compiler tests which does not match the actual cpu and cause false failures.
This change add the OMRPortLibrary to the test compiler environment.