Add support for dispatchJ9Method for MethodHandles on Z #7930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhall2
force-pushed
the
dispatchJ9Method_MH_Z
branch
5 times, most recently
from
399e043 to
6b5bf4d
Compare
matthewhall2
changed the title
matthewhall2
force-pushed
the
dispatchJ9Method_MH_Z
branch
7 times, most recently
from
0b1a391 to
37cacf5
Compare
Adds method to OMRNode to determine if node is jitDispatchJ9Method flushArgs skips first argument for S390HelperCallSnippet Signed-off-by: Matthew Hall <[email protected]>
matthewhall2
force-pushed
the
dispatchJ9Method_MH_Z
branch
from
37cacf5 to
8eab7dd
Compare
|
@r30shah can I get a review please? |
r30shah
suggested changes
Sep 25, 2025
| bool rightToLeft = linkage->getRightToLeft() && | ||
| // we want the arguments for induceOSR to be passed from left to right as in any other non-helper call | ||
| !callNode->getSymbolReference()->isOSRInductionHelper(); | ||
| !callNode->getSymbolReference()->isOSRInductionHelper() && !isJitDispatchJ9Method; |
There was a problem hiding this comment.
Just a recommendation to increase readability,
Suggested change
| !callNode->getSymbolReference()->isOSRInductionHelper() && !isJitDispatchJ9Method; | |
| !(callNode->getSymbolReference()->isOSRInductionHelper() || isJitDispatchJ9Method); |
| bool rightToLeft = self()->isParmsInReverseOrder() && | ||
| // we want the arguments for induceOSR to be passed from left to right as in any other non-helper call | ||
| !callNode->getSymbolReference()->isOSRInductionHelper(); | ||
| !callNode->getSymbolReference()->isOSRInductionHelper() && |
There was a problem hiding this comment.
Similar recommendation as previous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds method to OMRNode to determine if node is jitDispatchJ9Method
flushArgs skips first argument for S390HelperCallSnippet call call is jitDipatchJ9Method
needed for eclipse-openj9/openj9#22588