-
Notifications
You must be signed in to change notification settings - Fork 409
Off-heap related update #7956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LinHu2016
wants to merge
3
commits into
eclipse-omr:master
Choose a base branch
from
LinHu2016:defrag-offheap3_numa
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Off-heap related update #7956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinHu2016
added a commit
to LinHu2016/openj9
that referenced
this pull request
Sep 29, 2025
In PR eclipse-openj9#22116 and eclipse-openj9#22546, _arrayReservedRegionList and _sharedArrayReservedRegionsBytesUsed has been introduced to share fraction of reserved regions. _arrayReservedRegionList is set in commonAllocationContext(single global list), For numa case, the reserved regions for large array could be allocated from different allocation context(allocation context per numa node and in case there is no free region for the numa note, it could borrow from neighbor numa node). during recycling, there are no extra information indicate which reserved regions are for recycling off-heap array, so potentially it might cause imbalance free memory among numa notes, then affect runtime performance in some cases. Undate to manage reserved region list per allocation context(numa note) to avoid imbalance free memory caused by reserved regions. 1, for reducing complexity, shared fraction reserved regions still be managed in _arrayReservedRegionList of commom context. set _sharedReserved in AllocateDescriptor for shared fraction reserved region allocation. 2, new _allocationContextArray in SparseVirtualMemory(omr PR eclipse-omr/omr#7956) to store/retrieve allocation context for the reserved regions of large array. 3, handle allocation failure during getSparseAddressAndDecommitLeaves(). Signed-off-by: lhu <[email protected]>
b7cf399
to
c5e4f8c
Compare
LinHu2016
added a commit
to LinHu2016/openj9
that referenced
this pull request
Sep 30, 2025
In PR eclipse-openj9#22116 and eclipse-openj9#22546, _arrayReservedRegionList and _sharedArrayReservedRegionsBytesUsed has been introduced to share fraction of reserved regions. _arrayReservedRegionList is set in commonAllocationContext(single global list), For numa case, the reserved regions for large array could be allocated from different allocation context(allocation context per numa node and in case there is no free region for the numa note, it could borrow from neighbor numa node). during recycling, there are no extra information indicate which reserved regions are for recycling off-heap array, so potentially it might cause imbalance free memory among numa notes, then affect runtime performance in some cases. Undate to manage reserved region list per allocation context(numa note) to avoid imbalance free memory caused by reserved regions. 1, for reducing complexity, shared fraction reserved regions still be managed in _arrayReservedRegionList of commom context. set _sharedReserved in AllocateDescriptor for shared fraction reserved region allocation. 2, new _allocationContextArray in SparseVirtualMemory(omr PR eclipse-omr/omr#7956) to store/retrieve allocation context for the reserved regions of large array. 3, handle allocation failure during getSparseAddressAndDecommitLeaves(). Signed-off-by: lhu <[email protected]>
c5e4f8c
to
36804d3
Compare
@amicic @dmitripivkine : would one of you mind reviewing please? @LinHu2016 : The commit title and commit message needs to be more descriptive please. |
LinHu2016
added a commit
to LinHu2016/openj9
that referenced
this pull request
Oct 2, 2025
In PR eclipse-openj9#22116 and eclipse-openj9#22546, _arrayReservedRegionList and _sharedArrayReservedRegionsBytesUsed has been introduced to share fraction of reserved regions. _arrayReservedRegionList is set in commonAllocationContext(single global list), For numa case, the reserved regions for large array could be allocated from different allocation context(allocation context per numa node and in case there is no free region for the numa note, it could borrow from neighbor numa node). during recycling, there are no extra information indicate which reserved regions are for recycling off-heap array, so potentially it might cause imbalance free memory among numa notes, then affect runtime performance in some cases. Undate to manage reserved region list per allocation context(numa note) to avoid imbalance free memory caused by reserved regions. 1, for reducing complexity, shared fraction reserved regions still be managed in _arrayReservedRegionList of commom context. set _sharedReserved in AllocateDescriptor for shared fraction reserved region allocation. 2, new _allocationContextArray in SparseVirtualMemory(omr PR eclipse-omr/omr#7956) to store/retrieve allocation context for the reserved regions of large array. 3, handle allocation failure during getSparseAddressAndDecommitLeaves(). Signed-off-by: lhu <[email protected]>
LinHu2016
added a commit
to LinHu2016/openj9
that referenced
this pull request
Oct 5, 2025
In PR eclipse-openj9#22116 and eclipse-openj9#22546, _arrayReservedRegionList and _sharedArrayReservedRegionsBytesUsed has been introduced to share fraction of reserved regions. _arrayReservedRegionList is set in commonAllocationContext(single global list), For numa case, the reserved regions for large array could be allocated from different allocation context(allocation context per numa node and in case there is no free region for the numa note, it could borrow from neighbor numa node). during recycling, there are no extra information indicate which reserved regions are for recycling off-heap array, so potentially it might cause imbalance free memory among numa notes, then affect runtime performance in some cases. Undate to manage reserved region list per allocation context(numa note) to avoid imbalance free memory caused by reserved regions. 1, for reducing complexity, shared fraction reserved regions still be managed in _arrayReservedRegionList of commom context. set _sharedReserved in AllocateDescriptor for shared fraction reserved region allocation. 2, new _allocationContextArray in SparseVirtualMemory(omr PR eclipse-omr/omr#7956) to store/retrieve allocation context for the reserved regions of large array. 3, handle allocation failure during getSparseAddressAndDecommitLeaves(). Signed-off-by: lhu <[email protected]>
371d9e2
to
c206c21
Compare
new variable _sharedReserved in AllocateDescriptor to indicate that this allocation is related with shared reserved region. new _allocationContextArray in SparseVirtualMemory and related methods to keep/retrieve the allocation context of off-heap related reserved heap regions. Signed-off-by: lhu <[email protected]>
Signed-off-by: lhu <[email protected]>
This reverts commit 0c9d7cb.
c206c21
to
a6020b2
Compare
LinHu2016
added a commit
to LinHu2016/openj9
that referenced
this pull request
Oct 9, 2025
In PR eclipse-openj9#22116 and eclipse-openj9#22546, _arrayReservedRegionList and _sharedArrayReservedRegionsBytesUsed has been introduced to share fraction of reserved regions. _arrayReservedRegionList is set in commonAllocationContext(single global list), For numa case, the reserved regions for large array could be allocated from different allocation context(allocation context per numa node and in case there is no free region for the numa note, it could borrow from neighbor numa node). during recycling, there are no extra information indicate which reserved regions are for recycling off-heap array, so potentially it might cause imbalance free memory among numa notes, then affect runtime performance in some cases. Undate to manage reserved region list per allocation context(numa note) to avoid imbalance free memory caused by reserved regions. 1, for reducing complexity, shared fraction reserved regions still be managed in _arrayReservedRegionList of commom context. set _sharedReserved in AllocateDescriptor for shared fraction reserved region allocation. 2, new _allocationContextArray in SparseVirtualMemory(omr PR eclipse-omr/omr#7956) to store/retrieve allocation context for the reserved regions of large array. 3, handle allocation failure during getSparseAddressAndDecommitLeaves(). Signed-off-by: lhu <[email protected]>
LinHu2016
added a commit
to LinHu2016/openj9
that referenced
this pull request
Oct 10, 2025
In PR eclipse-openj9#22116 and eclipse-openj9#22546, _arrayReservedRegionList and _sharedArrayReservedRegionsBytesUsed has been introduced to share fraction of reserved regions. _arrayReservedRegionList is set in commonAllocationContext(single global list), For numa case, the reserved regions for large array could be allocated from different allocation context(allocation context per numa node and in case there is no free region for the numa note, it could borrow from neighbor numa node). during recycling, there are no extra information indicate which reserved regions are for recycling off-heap array, so potentially it might cause imbalance free memory among numa notes, then affect runtime performance in some cases. Undate to manage reserved region list per allocation context(numa note) to avoid imbalance free memory caused by reserved regions. 1, for reducing complexity, shared fraction reserved regions still be managed in _arrayReservedRegionList of commom context. set _sharedReserved in AllocateDescriptor for shared fraction reserved region allocation. 2, new _allocationContextArray in SparseVirtualMemory(omr PR eclipse-omr/omr#7956) to store/retrieve allocation context for the reserved regions of large array. 3, handle allocation failure during getSparseAddressAndDecommitLeaves(). Signed-off-by: lhu <[email protected]>
LinHu2016
added a commit
to LinHu2016/openj9
that referenced
this pull request
Oct 17, 2025
In PR eclipse-openj9#22116 and eclipse-openj9#22546, _arrayReservedRegionList and _sharedArrayReservedRegionsBytesUsed has been introduced to share fraction of reserved regions. _arrayReservedRegionList is set in commonAllocationContext(single global list), For numa case, the reserved regions for large array could be allocated from different allocation context(allocation context per numa node and in case there is no free region for the numa note, it could borrow from neighbor numa node). during recycling, there are no extra information indicate which reserved regions are for recycling off-heap array, so potentially it might cause imbalance free memory among numa notes, then affect runtime performance in some cases. Undate to manage reserved region list per allocation context(numa note) to avoid imbalance free memory caused by reserved regions. 1, for reducing complexity, shared fraction reserved regions still be managed in _arrayReservedRegionList of commom context. set _sharedReserved in AllocateDescriptor for shared fraction reserved region allocation. 2, new _allocationContextArray in SparseVirtualMemory(omr PR eclipse-omr/omr#7956) to store/retrieve allocation context for the reserved regions of large array. 3, handle allocation failure during getSparseAddressAndDecommitLeaves(). Signed-off-by: lhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new variable _sharedReserved in AllocateDescriptor to indicate that this allocation is related with shared reserved region.
new _allocationContextArray in SparseVirtualMemory and related methods to keep/retrieve the allocation context of off-heap related reserved heap regions.