-
Notifications
You must be signed in to change notification settings - Fork 409
Add code cache kind to TR_PrintCompMem printout #7987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add code cache kind to TR_PrintCompMem printout #7987
Conversation
This is an example of one of the code cache printouts with the new change
|
3e16ea7
to
b269f0d
Compare
compiler/runtime/OMRCodeCache.cpp
Outdated
{ | ||
fprintf(stderr, "Code Cache @%p flags=0x%x almostFull=%d\n", this, _flags, _almostFull); | ||
fprintf(stderr, "Code Cache @%p flags=0x%x almostFull=%d codeCacheKind=%s\n", this, _flags, _almostFull, | ||
TR::CodeCacheKindStrings[this->_kind]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't use '_kind' directly like '_flags'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably better to add a method to OMR::CodeCache
, perhaps even just a static method, so that you're not accessing the CodeCacheKindStrings
array directly.
0aaa8fe
to
c3257f0
Compare
c3257f0
to
5a839d1
Compare
Added more functionality, namely to print the code-base and code-top as well to make it easier to correlate with the verbose log This is an example of the new message
|
The TR_PrintCompMem printout displays various statistics about code cache usage for each code cache. This pr simply adds code cache kind to those statistics