WIP: Vnot IL opcode implementation on x86 platform#8258
Draft
JackZhuoyLi wants to merge 1 commit into
Draft
Conversation
Author
|
@gita-omr @IBMJimmyk here is my pull request |
JackZhuoyLi
force-pushed
the
add_vnot
branch
3 times, most recently
from
00f3d1d to
6ffec0a
Compare
gita-omr
reviewed
Jun 2, 2026
| TR::Register *OMR::X86::AMD64::TreeEvaluator::vnotEvaluator(TR::Node *node, TR::CodeGenerator *cg) | ||
| { | ||
| return TR::TreeEvaluator::unImpOpEvaluator(node, cg); | ||
| return TR::TreeEvaluator::unaryVectorArithmeticEvaluator(node, cg); |
Contributor
There was a problem hiding this comment.
I think it would be better to remove this method from the amd4 class and use the one from the parent.
| Inst_RegReg(movOpcode.getMnemonic(), node, resultReg, sourceReg, cg, movEncoding); | ||
| Inst_RegReg(xorOpcode.getMnemonic(), node, resultReg, onesReg, cg, xorEncoding); | ||
|
|
||
| if (node->getOpCode().isVectorMasked()) { |
Contributor
There was a problem hiding this comment.
Where does the actual masking happen?
| return TR::TreeEvaluator::floatingPointAbsHelper(node, cg); | ||
| } | ||
|
|
||
| if (opcode.getVectorOperation() == TR::vnot) { |
Contributor
There was a problem hiding this comment.
Where is the code for vmnot?
| TR::Register *OMR::X86::I386::TreeEvaluator::vnotEvaluator(TR::Node *node, TR::CodeGenerator *cg) | ||
| { | ||
| return TR::TreeEvaluator::unImpOpEvaluator(node, cg); | ||
| return TR::TreeEvaluator::unaryVectorArithmeticEvaluator(node, cg); |
Contributor
There was a problem hiding this comment.
Similar to amd64, better to not override this method and use the one in the parent.
JackZhuoyLi
force-pushed
the
add_vnot
branch
6 times, most recently
from
a44d7f5 to
3e99759
Compare
JackZhuoyLi
changed the title
…t operation across all integer types with masked operation support. Signed-off-by: Zhuoyang Li <zhuoyli@ibm.com>
JackZhuoyLi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the opcode vnot and vmnot tree evaluators in the parent class inside codegen files.
Added vnot helper function and used under unaryVectorArithmeticEvaluator.
Added new VnotTest.cpp unit test for testing proper vnot operations.
Signed-off-by: Zhuoyang Li zhuoyli@ibm.com