Skip to content

macOS toolchain update#8299

Open
knn-k wants to merge 1 commit into
eclipse-omr:masterfrom
knn-k:aarch64clangUpdate
Open

macOS toolchain update#8299
knn-k wants to merge 1 commit into
eclipse-omr:masterfrom
knn-k:aarch64clangUpdate

Conversation

@knn-k

@knn-k knn-k commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This commit adds type casts to some memcpy() and memset() calls, to avoid compilation failures with recent Xcode versions.

Co-authored-by: Kevin Grigorenko kevin.grigorenko@us.ibm.com

@knn-k
macOS toolchain update
2e0c518 
This commit adds type casts to some memcpy() and memset() calls, to
avoid compilation failures with recent Xcode versions.

Co-authored-by: Kevin Grigorenko <kevin.grigorenko@us.ibm.com>

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@knn-k knn-k force-pushed the aarch64clangUpdate branch from 7dfaef9 to 2e0c518 Compare June 23, 2026 23:44
@knn-k

knn-k commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Recent versions of Xcode fails without this change as shown below:

/Users/openj9/openj9-openjdk-jdk21/omr/compiler/il/NodePool.cpp:45:12: error: first argument in call to 'memset' is a pointer to non-trivially copyable type 'TR::Node' [-Werror,-Wnontrivial-memcall]
   45 |     memset(newNode, 0, sizeof(TR::Node));
      |            ^
/Users/openj9/openj9-openjdk-jdk21/omr/compiler/il/NodePool.cpp:45:12: note: explicitly cast the pointer to silence this warning

@knn-k

knn-k commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Jenkins build aarch64,amac

@knn-k

knn-k commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@knn-k knn-k mentioned this pull request Jun 24, 2026
Open
@knn-k knn-k marked this pull request as ready for review June 24, 2026 00:00
@knn-k knn-k mentioned this pull request Jun 24, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vijaysun-omr vijaysun-omr Awaiting requested review from vijaysun-omr vijaysun-omr is a code owner
@0xdaryl 0xdaryl Awaiting requested review from 0xdaryl 0xdaryl is a code owner
@mstoodle mstoodle Awaiting requested review from mstoodle mstoodle is a code owner

Assignees

No one assigned

Labels

arch:aarch64 os:macos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@knn-k