Skip to content

Update otterdog config per meeting on 6/24/2024 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions otterdog/eclipse-osee.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,14 @@ orgs.newOrg('technology.osee', 'eclipse-osee') {
delete_branch_on_merge: true,
gh_pages_build_type: "workflow",
web_commit_signoff_required: false,
dependabot_alerts_enabled: false,
has_discussions:true,
code_scanning_default_setup_enabled: true,
branch_protection_rules: [
orgs.newBranchProtectionRule('main') {
requires_linear_history: true,
required_approving_review_count: 2,
requires_conversation_resolution: true,
requires_strict_status_checks: true,
dismisses_stale_reviews: true,
required_status_checks : [
Expand Down
41 changes: 41 additions & 0 deletions otterdog/meeting_notes_6_24_2024
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
Proposed updates so far:

dependabot_alerts_enabled: false, -- we should use renovate instead

has_discussions: true, -- don’t see any sense in having this off. TODO:look into the api for github discussions to limit

actions_can_approve_pull_request_reviews: false – actions should not be able to merge into main by default

require_conversation_resolution: true – We want to people to close their review comments before merging.

Add branch settings to allow non-main, non-release branches(if we have any) to be deleted. Still TODO we need to investigate what branches if(any) that we will have for releases.

We will have to update status checks as they are made to block merge. (Note: status checks that don’t always run need a corollary always passing job).

code_scanning_default_setup_enabled: true if it doesn't have too many errors the first time

Limit bots making spam PRs – at some point

TENTATIVE(future meeting):

requires_code_owner_reviews : true – This will help protect our codebase as areas where we have PoCs can be guaranteed to be reviewed by someone who knows the area.

CODEOWNERS file

ATS Don/Vaibhav

Publishing Loren/David/Jaden?

DB Audrey/David/Luciano?

Test/SCA Stephen?

Authentication Luciano/Zach/David

IDE Client Don/David/Vaibhav/Loren/Jaden

Web Ryan|Luciano|Jaden

MIM Ryan|Luciano|Audrey

Build/Deploy Zach/Baily/Murshed?