Skip to content

feature[TW28966]: Prevent self modification in TaskMover #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
david-w-miller wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feature[TW28966]: Prevent self modification in TaskMover #400

david-w-miller wants to merge 1 commit into from

Conversation

@david-w-miller
Copy link
Contributor

@david-w-miller david-w-miller commented Sep 30, 2025

Fixes minor bug where a task moved a little and dropped on the same workflow caused a add/drop transaction.

@github-actions
Copy link

github-actions bot commented Sep 30, 2025

Playwright test results

failed  8 failed
passed  21 passed

Details

stats  29 tests across 14 suites
duration  14 minutes, 9 seconds
commit  44712cd

Failed tests

MIM Tests › mim/tests/create-icd.e2e-spec.ts › create transport type
MIM Tests › mim/tests/create-icd.e2e-spec.ts › create connection
MIM Tests › mim/tests/create-icd.e2e-spec.ts › create message and submessage
MIM Tests › mim/tests/create-icd.e2e-spec.ts › create structure
MIM Tests › mim/tests/create-icd.e2e-spec.ts › create elements
MIM Tests › mim/tests/create-icd.e2e-spec.ts › add array element
MIM Tests › mim/tests/traceability.e2e-spec.ts › trace report
SCA Tests › sca/tests/sca-select.e2e-spec.ts › test

jadenpuckett
jadenpuckett approved these changes Sep 30, 2025
View reviewed changes
.../org.eclipse.osee.ats.ide/src/org/eclipse/osee/ats/ide/workflow/task/internal/TaskMover.java
for (IAtsTask task : tasks) {
TaskArtifact taskArt = (TaskArtifact) task;
taskArt.clearCaches();
if (newParent.equals(taskArt.getParentAWA())) {
Copy link
Member

@jadenpuckett jadenpuckett Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if newParent is null?

Copy link
Contributor

@dondunne dondunne Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't be, but if you wanna check it won't hurt

@david-w-miller david-w-miller enabled auto-merge (rebase) September 30, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dondunne dondunne dondunne approved these changes

@jadenpuckett jadenpuckett jadenpuckett approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@david-w-miller @dondunne @jadenpuckett