Attempt to read entire MQTT packet#198
Open
mikegray wants to merge 1 commit intoeclipse-paho:masterfrom
mikegray:mike.read
Open
Attempt to read entire MQTT packet#198mikegray wants to merge 1 commit intoeclipse-paho:masterfrom mikegray:mike.read
mikegray wants to merge 1 commit intoeclipse-paho:masterfrom
mikegray:mike.read
Conversation
Signed-off-by: Mike Gray <mike@mikegray.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When MAX_MQTT_PACKET_SIZE is greater than the TCP receive buffer size, readPacket should try to read more from the ipstack. This fixes an issue I was facing with a message being 916 bytes, but the TCP receive buffer size for Mbed OS is 536 bytes. This will still exit if timer elapses or if the network data is not available.