Skip to content

add config support for TCP Bridges - #55

Open
andreas-ibm wants to merge 5 commits into
eclipse-paho:developfrom
andreas-ibm:master
Open

add config support for TCP Bridges#55
andreas-ibm wants to merge 5 commits into
eclipse-paho:developfrom
andreas-ibm:master

Conversation

@andreas-ibm

Copy link
Copy Markdown

This is only barely tested, and not all the configuration settings will be applied by TCPBridges (e.g. the prefixes haven't been implemented and in direction hasn't been implemented.

@icraggs

icraggs commented Aug 9, 2018

Copy link
Copy Markdown
Contributor

Hi Andreas. Thanks - you need to fix the IP checks before I could merge this:

"The pull request did not pass Eclipse validation.

The following users do not have valid ECAs:
amartens@uk.ibm.com

The following users have invalid Signed-off-by footers:
amartens@uk.ibm.com"

It's the Eclipse way - for which there are good reasons.

Signed-off-by: Andreas Martens <amartens@uk.ibm.com>
@andreas-ibm

Copy link
Copy Markdown
Author

yeah, saw the failures, took me a while to figure out how to "solve" them.. Think it's all done now?

@icraggs

icraggs commented Aug 9, 2018

Copy link
Copy Markdown
Contributor

Yep. All good now.

Signed-off-by: Andreas Martens <amartens@uk.ibm.com>
Signed-off-by: Andreas Martens <amartens@uk.ibm.com>
Signed-off-by: Andreas Martens <amartens@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants