message_passing: fix race condition in send queue#551
Merged
Conversation
kitsnet
force-pushed
the
nb_mp2_queue_fix
branch
from
16f38ad to
6819b7d
Compare
kitsnet
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
We were releasing SendCommand objects too early to the "free" pool, while temporarily unlocking the access to this pool for the time we spend in a SendProtocolMessage() call (as this call may result in a blocked IPC). During this temporary unlocking, another thread could obtain and reuse the same object, which could lead to message payload corruption under concurrent load. Now we are releasing these objects under re-obtained lock right after the message was sent.
kitsnet
force-pushed
the
nb_mp2_queue_fix
branch
from
6819b7d to
ccbf232
Compare
LittleHuba
approved these changes
Jun 17, 2026
github-project-automation
Bot
moved this from Backlog
to Done
in COM - Communication FT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were releasing SendCommand objects too early to the "free" pool, while temporarily unlocking the access to this pool for the time we spend in a SendProtocolMessage() call (as this call may result in a blocked IPC). During this temporary unlocking, another thread could obtain and reuse the same object, which could lead to message payload corruption under concurrent load.
Now we are releasing these objects under re-obtained lock right after the message was sent.