-
Notifications
You must be signed in to change notification settings - Fork 23
process: adjust testing levels and traceability #823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,44 +38,27 @@ Workflow Verification | |
The actual :need:`rl__committer` of the implementation can also be the creator of the unit tests. | ||
Independence is achieved by different approver at PRs and by the :need:`wp__verification__module_ver_report`. | ||
|
||
.. workflow:: Create/Maintain Component Test | ||
:id: wf__verification__comp_test | ||
:status: valid | ||
:tags: verification | ||
:responsible: rl__contributor | ||
:approved_by: rl__committer, rl__testing_community | ||
:supported_by: rl__safety_manager | ||
:input: wp__requirements__comp, wp__requirements__comp_aou, wp__verification__plan | ||
:output: wp__verification__component_test | ||
:contains: gd_req__link_tests, gd_guidl__verification_specification | ||
:has: doc_concept__verification__process, doc_getstrt__verification__process | ||
|
||
Component test cases are based on component requirements. | ||
Any contributor can create a component test and create a PR for it. | ||
During the review process the test cases will be approved by a committer. | ||
Committer and contributor need to differ. | ||
The tests are automatically executed as part of the CI after PR merge. | ||
In case of changes at inputs, the workflow need to be executed again as part of maintenance. | ||
|
||
.. workflow:: Create/Maintain Component Integration Test | ||
:id: wf__verification__comp_int_test | ||
:status: valid | ||
:tags: verification | ||
:responsible: rl__contributor | ||
:approved_by: rl__committer, rl__testing_community | ||
:supported_by: rl__safety_manager | ||
:input: wp__component_arch, wp__sw_implementation, wp__verification__plan | ||
:input: wp__component_arch, wp__sw_implementation, wp__requirements__comp, wp__requirements__comp_aou, wp__verification__plan | ||
:output: wp__verification__comp_int_test | ||
:contains: gd_req__link_tests, gd_guidl__verification_specification | ||
:has: doc_concept__verification__process, doc_getstrt__verification__process | ||
|
||
Component Integration test cases are based on component architecture and detailed design of implementation. | ||
Component Integration test cases are based on component architecture and component requirements. | ||
They may optionally cover the detailed design of implementation as an optional element where units are seen complex. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would not say so. The detailed design describes the the units forming a component and their interactions - see https://eclipse-score.github.io/score/main/process/process_areas/implementation/_assets/detailed_design_example.html - so the interfaces and interactions between units can be used as a basis for testing. Maybe rather make the integration testing of component architecture optional (in case a component has no (sub-)components. |
||
Any contributor can create a component integration test and create a PR for it. | ||
During the review process the test cases will be approved by a committer. | ||
Committer and contributor need to differ. | ||
The tests are automatically executed as part of the CI after PR merge. | ||
In case of changes at inputs, the workflow need to be executed again as part of maintenance. | ||
|
||
|
||
.. workflow:: Create/Maintain Feature Integration Test | ||
:id: wf__verification__feat_int_test | ||
:status: valid | ||
|
@@ -165,7 +148,7 @@ Workflow Verification | |
wp__component_arch, wp__module_sw_release_note, wp__platform_mgmt, | ||
wp__sw_component_safety_analysis, wp__sw_component_dfa, | ||
wp__sw_arch_verification, wp__sw_implementation_inspection, wp__requirements__inspect, | ||
wp__verification__component_test, wp__verification__comp_int_test, wp__verification__sw_unit_test | ||
wp__verification__comp_int_test, wp__verification__sw_unit_test | ||
:output: wp__verification__module_ver_report | ||
:contains: gd_temp__mod_ver_report | ||
:has: doc_concept__verification__process, doc_getstrt__verification__process | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what is still unclear: are the component integration tests 6-9 or 6-10? In the SW verification plan it seems to say that "level 1" is 6-9. Is this what you want to say? And I also think we need to explain better what a "Unit Tester" has to do in the guideline: 1. read the Detailed Desig, create a test for every interface of the unit showing at least every flow in dynamic diagrams, 2. follow the DD to the component requirements - test these 3. fill attributes including test description 4. link test to ??? (not component requirements)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From WG working meeting 6-10 goes down to green "Component".
6-9 is for grey part.
Unclear is the handling of requirements.
Start with the simple use case (without Component architecture due to unit simplicity)
Detailed design is directly related to component requirements and implicitly covered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking if we not just also add a link from Unit Test to the Component Requirements. Reasoning is that this would be also easier to demonstrate a full requirement coverage by testing. But also we should keep the DD link possibility for unit test because we do want also the possibility to test DD instead have a Component requirement for everything - maybe best to say you have to have one or the other.