tooling: Reduce 2 types of Pylance new warnings and more #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix pylance warnings for reportMissingTypeArgument and reportUnusedVariable and some other warnings. Also-by: Aymen Soussi [email protected]
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
| @@ -247,7 +248,7 @@ def draw_module( | |||
| structure_text += f"}} /' {need['title']} '/ \n\n" | |||
|
|
|||
| # Add logical interfaces only to implemented interfaces | |||
| for iface, component in proc_impl_interfaces.items(): | |||
| for iface, _ in proc_impl_interfaces.items(): | |||
There was a problem hiding this comment.
Suggested change
| for iface, _ in proc_impl_interfaces.items(): | |
| for iface in proc_impl_interfaces: |
There was a problem hiding this comment.
Fixed. Please resolve.
|
|
||
| # from score_metamodel import ( | ||
| # CheckLogger, | ||
| # graph_check, | ||
| # ) | ||
|
|
||
|
|
||
| def get_standards_needs(needs: list[NeedsInfoType]) -> dict: | ||
| def get_standards_needs(needs: list[dict[str, Any]]) -> dict[str, dict[str, Any]]: |
There was a problem hiding this comment.
Would it make sense to somehow extend NeedsInfoType with our keys? A generic dict is extremely unspecific.
There was a problem hiding this comment.
Might make sense to extend it or wrap it?
Just have to be careful to not end up with 200 custom NeedsInfoTypes Dataclasses in teh end.
There was a problem hiding this comment.
Maybe one in score_metamodel/__init__.py?
https://chatgpt.com/share/67f4f048-6930-800a-8a49-b3a54cece1b4
There was a problem hiding this comment.
I guess it make more sence to do it in a seperate PR later if you agree guys as I tried to change some other files containing all_needs with NeedTypeInfo in state of list[dict[str, Any]] or other definitions but I end up getting more warnings and errors but for the file standards I already changed now with no side effects
| @@ -35,7 +35,7 @@ def assert_no_warnings(self): | |||
| ) | |||
| pytest.fail(f"Expected no warnings, but got:\n{warnings}") | |||
|
|
|||
| def assert_warning(self, expected_substring: str, expect_location=True): | |||
| def assert_warning(self, expected_substring: str, expect_location: bool = True): | |||
There was a problem hiding this comment.
Good example where annotating every parameter is useless :/
There was a problem hiding this comment.
Yes, I agree.
| @@ -67,7 +68,7 @@ | |||
| needs_template_folder = "_templates" | |||
| needs_global_options = {"collapse": True} | |||
| html_static_path = ["_tooling/assets", "_assets"] | |||
| needs_string_links = { | |||
| needs_string_links: dict[str, dict[str, Any]] = { | |||
There was a problem hiding this comment.
was this required by any of the rules we have introduced? That was not intentional.
There was a problem hiding this comment.
It's role reportUnknownVariableType that throw this warning
dcalavrezo-qorix
approved these changes
Apr 8, 2025
AlexanderLanin
requested changes
Apr 8, 2025
AlexanderLanin
approved these changes
Apr 8, 2025
AlexanderLanin
added
the
community:infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pylance warnings for reportMissingTypeArgument and reportUnusedVariable and some other warnings.
Also-by: Aymen Soussi [email protected]
Related to: #836