-
Notifications
You must be signed in to change notification settings - Fork 23
process: add initial tool management #932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-check Status: ✅ Passed Click to expand output
|
The created documentation from the pull request is available at: docu-html |
3242aa0
to
af8341c
Compare
af8341c
to
c0e3042
Compare
c0e3042
to
f8a7453
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see inline comments
|
||
In case you want to use a tool within **S-CORE** consider to: | ||
|
||
* Create your Tool Verification Report according to :need:`wf__tool__create_tool_verification_report` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First I think one should consider the tool list, if the tool and its use case is already part of it. And then one should follow the tool user guide. And only if it is not already there ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modified
|
||
The Tool Verification Report is created during identification of a tool. | ||
|
||
Each identified tool to is evaluated and if applicable, qualified. During evaluation and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo "to"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed
|
||
Finally the Tool Verification Report is verified and approved, and thus in Released state. | ||
|
||
For creating the Tool Verification Report template must be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grammar "a template"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed
proper tool documentation, guidelines, protection against malware introduction, etc. | ||
|
||
Based on TCL the appropriate qualification methods shall be applied. For S-CORE per default | ||
the method validation of software tool must be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider to put the method name in "" for better readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed
Tool Management Checklist | ||
######################### | ||
|
||
.. gd_chklst:: Tool Verification Report Review Checklist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mismatch to title above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed
------------- | ||
[Describe here detailed information about the tool documentation] | ||
|
||
Where are the tool documents like User Manual, Guidelines, Erratas, etc. located? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to have a tool list with all the information relevant for a user linked. So maybe we create a "tool" need with the respective attributes and generate the list from these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see below, tool list exist, but not on need, but id, tags, let's discuss the better approach in next meeting
- | ||
|
||
* - 20 | ||
- If applicable, are the analyses for software tool qualification defined? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see also below: analysis needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make it optional, let's discuss in next meeting
For each tool the :need:`gd_temp__tool_management__verif_rpt_template` shall be used to document | ||
the relevant information. | ||
|
||
:need:`gd_chklst__tool__cr_review` may used to check that all relevant information is considered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sentence unclear, needed? why only "may"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed, may was there, if it enforced by tool, may not needed?
|
||
**To Step 3** | ||
|
||
If tool impact is judged to "YES" and tool error detection judged to "YES", the tool confidence |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be "and tool error detection judged to "NO""
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed
.. list-table:: SW Platform tool overview | ||
:header-rows: 1 | ||
|
||
* - tool Id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more a tool list for the "safety and security management". I would like to add here info/links relevant to the user like version, user manual, use case (or at least state that these are part of the "verification report").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add link, but see comment above, how to create tool list
Resolves: #858
f8a7453
to
37c6d46
Compare
Resolves: #858