Test/license handler coverage#3737
Open
avadhutmali wants to merge 2 commits intoeclipse-sw360:mainfrom
Open
Conversation
avadhutmali
requested review from
GMishx,
KoukiHama,
ag4ums and
arunazhakesan
as code owners
GMishx
added
needs code review
needs general test
Member
|
@avadhutmali please fix the CI pipeline and sign your ECA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test coverage for updateWhitelist and addObligationsToLicense, which
had no tests before. Put the new tests in a separate file to keep
LicenseHandlerTest.java untouched. Also pulled out the shared setup code
into a base class so adding more tests later is easier.
Fixes #3736
No new dependencies.
Suggest Reviewer
How To Test?
New tests run through the normal CI pipeline. 4 test cases added:
Checklist
Must: