refactor(backend) : extract persistence logic in LicenseDatabaseHandler#3755
Open
clapppp wants to merge 2 commits intoeclipse-sw360:mainfrom
Open
refactor(backend) : extract persistence logic in LicenseDatabaseHandler#3755clapppp wants to merge 2 commits intoeclipse-sw360:mainfrom
clapppp wants to merge 2 commits intoeclipse-sw360:mainfrom
Conversation
Signed-off-by: Suhyeon Park <ssantta999@gmail.com>
clapppp
requested review from
GMishx,
KoukiHama,
ag4ums and
arunazhakesan
as code owners
GMishx
added
needs code review
needs general test
GMishx
added
ready
Member
|
Hey @clapppp thanks for the explanation as this PR currently did not made any sense. However, I am not merging this PR as of now as are in process of tagging a release and this might be a breaking change and require thorough testing. Thus, I am just marking it as ready to be merged after the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR refactors the
updateLicensemethod inLicenseDatabaseHandler.javato extract the core CouchDB persistence logic into a separate, dedicated helper method (persistLicenseAndChangelogs).Motivation (Preparation for GSoC 2026 Idea):
By isolating the persistence logic, this refactoring lays the necessary groundwork for GSoC 2026 Idea : Integration of SW360 and LicenseDB. When the future Sync Engine fetches license data from the external LicenseDB, it can directly reuse this extracted method to update the local CouchDB cache and maintain changelog history, without duplicating code or bypassing manual validation flows.
Did you add or update any new dependencies that are required for your change?
No, this is a pure structural refactoring (Extract Method). No new dependencies were added.
Checklist
Must: