Skip to content

fix(rest): update clearing request after editing in request tab.#3756

Open
nikkuma7 wants to merge 1 commit intomainfrom
fix/updateRequest
Open

fix(rest): update clearing request after editing in request tab.#3756
nikkuma7 wants to merge 1 commit intomainfrom
fix/updateRequest

Conversation

@nikkuma7
Copy link
Contributor

@nikkuma7 nikkuma7 commented Feb 25, 2026 •
edited
Loading

Please provide a summary of your changes here.

  • Which issue is this pull request belonging to and how is it solving it? (Refer to issue here)
  • Did you add or update any new dependencies that are required for your change?

Fixes: Closes #3757

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

  1. Navigate to the Request tab
  2. Select any Clearing Request (CR) from the list
  3. Click the Edit button to open the request in edit mode
  4. Make changes to the clearing request fields (eg. priority)
  5. Click the Save button

How should these changes be tested by the reviewer?
Have you implemented any additional tests?

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@GMishx GMishx added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Feb 25, 2026
GMishx
GMishx previously approved these changes Feb 25, 2026
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@GMishx
Copy link
Member

GMishx commented Feb 25, 2026

@nikkuma7 Exposing the TException is making the test cases fail. Please recheck the logic of test cases
https://github.com/eclipse-sw360/sw360/actions/runs/22389872854/job/64808870169?pr=3756#step:13:6396

@nikkuma7 nikkuma7 force-pushed the fix/updateRequest branch 2 times, most recently from 89f18a1 to 7d945b9 Compare February 27, 2026 07:58
@GMishx
Copy link
Member

GMishx commented Mar 2, 2026

@nikkuma7 , please fix the test cases. Do not change the exception as per the test-case.

@nikkuma7
fix(rest): update clearing request after editing in request tab
b2c715a 
Signed-off-by: Nikesh Kumar <kumar.nikesh@siemens.com>
@nikkuma7 nikkuma7 force-pushed the fix/updateRequest branch from 7d945b9 to b2c715a Compare March 2, 2026 09:08
GMishx
GMishx approved these changes Mar 2, 2026
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GMishx GMishx GMishx approved these changes

@KoukiHama KoukiHama Awaiting requested review from KoukiHama KoukiHama is a code owner

@arunazhakesan arunazhakesan Awaiting requested review from arunazhakesan arunazhakesan is a code owner

@ag4ums ag4ums Awaiting requested review from ag4ums ag4ums is a code owner

Assignees

@nikkuma7 nikkuma7

Labels

needs code review needs general test This is general testing, meaning that there is no org specific issue to check for

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(Rest): Clearing request update failure.

2 participants

@nikkuma7 @GMishx