test(licenses): add test coverage for LicenseHandler methods - Fixes #3736#3758
Open
ADITYA-CODE-SOURCE wants to merge 1 commit intoeclipse-sw360:mainfrom
Open
Conversation
ADITYA-CODE-SOURCE
requested review from
GMishx,
KoukiHama,
ag4ums and
arunazhakesan
as code owners
Adds test coverage for the following methods that previously had no tests: - testDeleteLicense: Test deleting a license - testDeleteLicenseNonAdmin: Test that non-admin cannot delete license - testAddLicenseType: Test adding a new license type - testAddLicenseTypeNonAdmin: Test that non-admin cannot add license type - testDeleteLicenseType: Test deleting a license type - testGetLicenseSummaryForExport: Test getting license summary - testGetLicenseTypes: Test getting all license types - testDeleteNonExistentLicense: Test deleting non-existent license - testDeleteNonExistentLicenseType: Test deleting non-existent license type Fixes eclipse-sw360#3736
ADITYA-CODE-SOURCE
force-pushed
the
fix/3736-license-handler-test-coverage
branch
from
37a6a6c to
a204e8d
Compare
Contributor
Author
|
Hello sir @GMishx,
|
GMishx
added
needs code review
needs general test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds test coverage for LicenseHandler methods that previously had no tests, addressing issue #3736.
Changes Made
Added new test file
LicenseHandlerAdditionalTest.javawith comprehensive tests for:Issue
This PR fixes #3736
Dependencies
No new dependencies added.
Suggest Reviewer
@GMishx @KoukiHama @ag4ums @arunazhakesan
How To Test?
The new tests can be run using:
All 9 new test cases should pass:
Checklist
Must: