fix(backend): close FileInputStream in SvmConnector to prevent resour…#3764
Open
melbiialy wants to merge 1 commit intoeclipse-sw360:mainfrom
Open
fix(backend): close FileInputStream in SvmConnector to prevent resour…#3764melbiialy wants to merge 1 commit intoeclipse-sw360:mainfrom
melbiialy wants to merge 1 commit intoeclipse-sw360:mainfrom
Conversation
…ce leak The keyStore.load() method doesn't close the inputstream. This caused file handle leaks when loading SSL certificates for SVM connections. Changed line 88 in createSslSocketFactoryForSVM() to use try-with-resources pattern to ensure the FileInputStream is properly closed even when exceptions occur. Signed-off-by: Elbialy0 <mahmoudelbialy109@gmail.com>
melbiialy
requested review from
GMishx,
KoukiHama,
ag4ums and
arunazhakesan
as code owners
GMishx
added
needs code review
needs general test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed a resource leak in
SvmConnector.createSslSocketFactoryForSVM()where aFileInputStreamwas not being properly closed. TheKeyStore.load()method does not close the providedInputStreamaccording to Java API documentation, causing file handle leaks when loading SSL certificates for SVM connections.Changed line 88 in
backend/common/src/main/java/org/eclipse/sw360/datahandler/db/SvmConnector.javato use try-with-resources pattern:Before:
After:
This ensures the
FileInputStreamis properly closed even when exceptions occur, preventing:Fixes #3763
Suggested Reviewers
@GMishx