fix(cyclonedx): preserve component group in BOM import to prevent name collisions#3787
Open
MrButtCode wants to merge 1 commit intoeclipse-sw360:mainfrom
Open
fix(cyclonedx): preserve component group in BOM import to prevent name collisions#3787MrButtCode wants to merge 1 commit intoeclipse-sw360:mainfrom
MrButtCode wants to merge 1 commit intoeclipse-sw360:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #2298 where the CycloneDX importer silently discards the group field, leading to name collisions and incorrect component merging during deduplication.
Changes:
Testing:
Migration Considerations:
As noted in my analysis on the issue thread, existing components in a user's database previously imported without groups (e.g., browser) will not automatically merge with new imports containing groups (e.g., @sentry/browser). Users may need to re-import affected SBOMs for clean data.
Related Issue:
Fixes #2298
Detailed architectural analysis can be found in my comment on the issue thread: #2298 (comment)