Skip to content

Conversation

@cdamus
Copy link

@cdamus cdamus commented Dec 22, 2025

What it does

As of macOS Tahoe, icons that are not squircles are forced into ugly grey squircles by the OS. Compose a new icon compatible with Tahoe. Update electron-builder to support the new Icon Composer icon format.

Fixes #456

How to test

Run an Electron package build: yarn electron package and launch the Electron app on macOS. You should see something like this in the Dock:

CleanShot 2025-12-22 at 09 08 31@2x

Review checklist

Reminder for reviewers

As of macOS Tahoe, icons that are not squircles are forced into ugly
grey squircles by the OS. Compose a new icon compatible with Tahoe.
Update electron-builder to support the new Icon Composer icon format.

Fixes eclipse-theia#456

Signed-off-by: Christian W. Damus <[email protected]>
@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Dec 22, 2025
@sgraband
Copy link
Contributor

sgraband commented Jan 7, 2026

@cdamus Thank you for the changes! It seems like we now have issues with our build infrastructure, as the .icon (Icon Composer file) is not yet supported in macos-15. We use macos-15 because this mimics our runner for the release afaik. @jfaltermeier It would be quite the effort to update that one, right? Or would we lose compatibility with older mac versions?

@jfaltermeier
Copy link
Contributor

We switched to 15 because the old mac runner for Intel architecture was deprecated, and they added a new label for macOS 15, see actions/runner-images#13045.

This is the last runner with Intel arch, so I think we are stuck with this until we drop support for Intel.

@cdamus
Copy link
Author

cdamus commented Jan 7, 2026

Ah, OK. Perhaps then I'll export an icon.icns from the Icon Composer project and leave the build otherwise unchanged.

Generate an ICNS file out of the new Icon Composer project.

Signed-off-by: Christian W. Damus <[email protected]>
@cdamus
Copy link
Author

cdamus commented Jan 8, 2026

Commit ecff29f exports the Icon Composer project as an *.icns file and uses that in the build. So the Electron Builder dependency upgrade then can also be reverted.

Unfortunately, it does appear that, despite being obviously squircle-shaped and exported from Icon Composer on macOS Tahoe, this icon does nonetheless end up in the Squircle Jail. Oh, well. It still looks better than before.

CleanShot 2026-01-08 at 15 34 31@2x

@ndoschek
Copy link
Member

ndoschek commented Jan 9, 2026

Hi @cdamus, thanks for this improvement!
Unfortunately, I caused a conflict as I just merged a PR that renamed the icon directories, but hopefully the rebase will be quick.
I'll ask Colin to take a look at this PR. Thanks!

…icon

Signed-off-by: Christian W. Damus <[email protected]>

# Conflicts:
#	applications/electron/electron-builder.yml
#	applications/electron/resources/icons/MacLauncherIcons/icon.icns
#	applications/electron/resources/icons/MacLauncherIcons/icon.icon/Assets/Theia Dark BG.jpg
#	applications/electron/resources/icons/MacLauncherIcons/icon.icon/Assets/Theia Light BG.jpg
#	applications/electron/resources/icons/MacLauncherIcons/icon.icon/Assets/icon.png
#	applications/electron/resources/icons/MacLauncherIcons/icon.icon/icon.json
@cdamus
Copy link
Author

cdamus commented Jan 9, 2026

Commit 4a32386 resolves the conflicts.

Replace the icon.icns with one built using a newer Electron Builder from
the Icon Composer project on Tahoe.

Signed-off-by: Christian W. Damus <[email protected]>
@cdamus
Copy link
Author

cdamus commented Jan 9, 2026

I've pushed a new icon file that was built using the latest Electron Builder on Tahoe from the Icon Composer project. It is a different result from the one I pushed previously, which was built from an iconset of PNGs via iconutil. Perhaps it will break out of Squircle Jail.

@cdamus
Copy link
Author

cdamus commented Jan 10, 2026

I've pushed a new icon file that was built using the latest Electron Builder on Tahoe from the Icon Composer project. It is a different result from the one I pushed previously, which was built from an iconset of PNGs via iconutil. Perhaps it will break out of Squircle Jail.

It seems to work. Tahoe is not interfering with this icon

CleanShot 2026-01-10 at 15 59 43@2x

Copy link

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on Tahoe 👍

@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Needs merge in PR Backlog Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs merge

Development

Successfully merging this pull request may close these issues.

Dock icon on macOS should be a squircle

5 participants