-
Notifications
You must be signed in to change notification settings - Fork 212
App icon compatible with macOS Tahoe #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
As of macOS Tahoe, icons that are not squircles are forced into ugly grey squircles by the OS. Compose a new icon compatible with Tahoe. Update electron-builder to support the new Icon Composer icon format. Fixes eclipse-theia#456 Signed-off-by: Christian W. Damus <[email protected]>
|
@cdamus Thank you for the changes! It seems like we now have issues with our build infrastructure, as the |
|
We switched to 15 because the old mac runner for Intel architecture was deprecated, and they added a new label for macOS 15, see actions/runner-images#13045. This is the last runner with Intel arch, so I think we are stuck with this until we drop support for Intel. |
|
Ah, OK. Perhaps then I'll export an |
Generate an ICNS file out of the new Icon Composer project. Signed-off-by: Christian W. Damus <[email protected]>
|
Commit ecff29f exports the Icon Composer project as an Unfortunately, it does appear that, despite being obviously squircle-shaped and exported from Icon Composer on macOS Tahoe, this icon does nonetheless end up in the Squircle Jail. Oh, well. It still looks better than before.
|
|
Hi @cdamus, thanks for this improvement! |
…icon Signed-off-by: Christian W. Damus <[email protected]> # Conflicts: # applications/electron/electron-builder.yml # applications/electron/resources/icons/MacLauncherIcons/icon.icns # applications/electron/resources/icons/MacLauncherIcons/icon.icon/Assets/Theia Dark BG.jpg # applications/electron/resources/icons/MacLauncherIcons/icon.icon/Assets/Theia Light BG.jpg # applications/electron/resources/icons/MacLauncherIcons/icon.icon/Assets/icon.png # applications/electron/resources/icons/MacLauncherIcons/icon.icon/icon.json
|
Commit 4a32386 resolves the conflicts. |
Replace the icon.icns with one built using a newer Electron Builder from the Icon Composer project on Tahoe. Signed-off-by: Christian W. Damus <[email protected]>
|
I've pushed a new icon file that was built using the latest Electron Builder on Tahoe from the Icon Composer project. It is a different result from the one I pushed previously, which was built from an iconset of PNGs via |
colin-grant-work
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me on Tahoe 👍


What it does
As of macOS Tahoe, icons that are not squircles are forced into ugly grey squircles by the OS. Compose a new icon compatible with Tahoe. Update electron-builder to support the new Icon Composer icon format.
Fixes #456
How to test
Run an Electron package build:
yarn electron packageand launch the Electron app on macOS. You should see something like this in the Dock:Review checklist
Reminder for reviewers