Use SimpleMonacoEditor for most inline editors #15389
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #15218
Adds a new function
createSimpleInline
to theMonacoEditorProvider
that returns an instance ofSimpleMonacoEditor
that is more customizable than our standardMonacoEditor
, allowing customization of both services, which theMonacoEditor
also does, and editor contributions, which theMonacoEditor
does not, and 'simplicity', which theMonacoEditor
also doesn't. Control of contributions is the more direct way to control the presence or absence, rather than behavior, of certain features: remove the inlay hints contribution, and the editor won't have inlay hints, etc.See discussion on issue re: current design.
How to test
Note that currently, all three editors are instantiated with a full complement of both services and editor contributions - the primary difference in behavior is from setting
isSimpleWidget
to true; see discussion here.Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers