Rely on Virtuoso's onAtBottomStateChange for scroll locking#17728
Open
colin-grant-work wants to merge 2 commits into
Open
Rely on Virtuoso's onAtBottomStateChange for scroll locking#17728colin-grant-work wants to merge 2 commits into
colin-grant-work wants to merge 2 commits into
Conversation
CamilleLetavernier
approved these changes
Jun 30, 2026
CamilleLetavernier
left a comment
Contributor
There was a problem hiding this comment.
Thanks Colin! The changes look good to me and seem to work fine so far.
The loss of directional check may have one downside: it can be difficult in some cases to get unstuck from the bottom, since you need to reach the 30px threshold to trigger scroll-lock (so it can be a bit tricky for slow scroll events while the LLM is still talking). But if this means the overall scroll behavior is more reliable and stable, then this is a reasonable trade-off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Simplifies the scroll lock mechanisms implemented for the AI chat view to depend on Virtuoso's own
onAtBottomStateChangedcallback mechanism. In testing, this seems to reduce scroll jiggle and be more reliable than the current implementation.How to test
Follow-ups
Breaking changes
Attribution
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers