[variable-resolver] Keep task input prompts open - #17917
Open
mehedi-107 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Md. Mehedi Hasan <2105052@ugrad.cse.buet.ac.bd>
Signed-off-by: Md. Mehedi Hasan <2105052@ugrad.cse.buet.ac.bd>
mehedi-107
marked this pull request as ready for review
August 13, 2026 19:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17894.
Summary
Task input prompts were closing when focus moved away, for example after clicking in the Explorer. That is disruptive because the task is still waiting for a value.
This change keeps both
promptStringandpickStringtask inputs open when focus moves elsewhere. A task now proceeds only after the user selects a value or confirms the text input. Pressing Escape cancels the task cleanly instead of leaving a partially resolved task running.While testing the cancellation path, I also found that cancelling an input could leave a shell task without its arguments. With the example task, that meant starting
nodeby itself and leaving a Node prompt running. The process task resolver now stops task resolution when a command or its arguments are cancelled.Manual testing
Using
packages/task/test-resources/.theia/tasks.jsonand Task: Run Task:b, selectedc, and confirmed the task completed with the expected arguments:a b c.Automated checks
Passed locally:
npm run compile --workspace=@theia/tasknpm run compile --workspace=@theia/variable-resolvernpm test --workspace=@theia/variable-resolver(12 passing)./node_modules/.bin/mocha --config ./configs/mocharc.yml ./packages/task/lib/browser/process/process-task-resolver.spec.js(1 passing)npm run lint --workspace=@theia/tasknpm run lint --workspace=@theia/variable-resolvergit diff --checkpackages/task/test-resources/.theia/tasks.jsonThe complete
@theia/tasksuite could not be started locally because the current Node 24 environment is missing the unrelated nativedrivelistbinding. The modified packages compile cleanly, and the focused regression tests pass.