Skip to content

Conversation

@mrdeep1
Copy link
Contributor

@mrdeep1 mrdeep1 commented Apr 24, 2023

Remove include clashes, in particular with files named as global.h and session.h when used with other projects.

Future work could be to move the header files into a include/tinydtls directory, so that all of the includes are of the form "tinydtls/dtls_global.h" etc.

@boaks
Copy link
Contributor

boaks commented Apr 26, 2023

While I appreciate improvements, I'm not sure, if changing that many files with a couple of large/mid size PRs open.
Luckily, this project is overall "tiny", so I don't see any real issue with it.

LGTM.

@obgm
Copy link
Contributor

obgm commented Jul 14, 2023

I completely agree with @boaks
We can fix the conflicts and merge this PR once the big PRs are pulled in.

Remove include clashes, in particular with files named as global.h
and session.h when used with other projects.

Signed-off-by: Jon Shallow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants