Background bookmarks #214
Merged
Background bookmarks #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses bug 211 [Added] Ability to have background markers Change-Id: Ie681f5577b5e9abdb8ebeb75c456f860625af1cb Signed-off-by: Matthew Khouzam <[email protected]> Signed-off-by: Arnaud Fiorini <[email protected]>
The original alpha made it harder to read. [Changed] reduced default alpha on bookmarks Change-Id: I692d19d51bef2fa4bf41b3b763e21547b89e9444 Signed-off-by: Matthew Khouzam <[email protected]>
arfio
approved these changes
Oct 23, 2025
Contributor
arfio
left a comment
arfio
left a comment
There was a problem hiding this comment.
I rebased the change and added a since tag. Otherwise I tested the change and reviewed the code, LGTM overall!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Changes the bookmarks widget to add the option to have background images. Fixes #211
How to test
Follow-ups
Review checklist