Chore/refactor direction characteristics#1128
Open
jakoballgaier wants to merge 7 commits into
Open
Conversation
ReneSchroederLJ
requested changes
Apr 2, 2026
Member
ReneSchroederLJ
left a comment
ReneSchroederLJ
left a comment
There was a problem hiding this comment.
Thank you for the contribution. Looks fine for the most part.
In addition to my comment please also move the DirectionCharacteristic class to common/samm. Currently multiple SAMM models are referencing it so it shouldn't be in the stock folder.
Member
|
My bad for being too quick with the review, but the app is not building due to missing columns. Please fix. |
…apter tables - erp_adapter_request: SMALLINT → VARCHAR(255) - erp_adapter_trigger_dataset: rename only (already VARCHAR)
ReneSchroederLJ
requested changes
Apr 7, 2026
Member
ReneSchroederLJ
left a comment
ReneSchroederLJ
left a comment
There was a problem hiding this comment.
Looks good. just one small copyright header issue left.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resolves #1109
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:
changelog.md) with PR reference and brief summary.frontend/package.json,frontend/package-lock.json)backend/pom.xml)scripts/generate_openapi_yaml.pywith running customer backend)