feat: Update table row height and selection behavior#1135
Open
jakoballgaier wants to merge 3 commits into
Open
feat: Update table row height and selection behavior#1135jakoballgaier wants to merge 3 commits into
jakoballgaier wants to merge 3 commits into
Conversation
ReneSchroederLJ
requested changes
Apr 14, 2026
Member
ReneSchroederLJ
left a comment
ReneSchroederLJ
left a comment
There was a problem hiding this comment.
Thank you for the fix. I just suggested a small improvement
| getRowId={(row) => row.ownMaterialNumber} | ||
| noRowsMsg='No materials found' | ||
| getRowHeight={() => "auto"} | ||
| disableRowSelectionOnClick |
Member
There was a problem hiding this comment.
This still allows row selection by keyboard. A more complete approach would be to utilize rowSelection={false}
ReneSchroederLJ
requested changes
Apr 14, 2026
Member
ReneSchroederLJ
left a comment
ReneSchroederLJ
left a comment
There was a problem hiding this comment.
Upon reviewing your changes again I noticed that these fixes weren't applied to the tables in the batch view. The selection fix only applies to the table within the modal, but the row height fix should be applied to both.
My apologies for not catching this the first time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:
changelog.md) with PR reference and brief summary.frontend/package.json,frontend/package-lock.json)backend/pom.xml)scripts/generate_openapi_yaml.pywith running customer backend)