add support for QNX 7.1/8.0 #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix path for build artifacts
fix path for build artifacts
|
Code coverage report is ready! 📈
|
PLeVasseur
approved these changes
May 11, 2025
There was a problem hiding this comment.
Thanks @pkleymonov-qnx for the contribution!
Could you open an issue for adding tests for building for QNX in CI as well?
fix whitespace Co-authored-by: Pete LeVasseur <[email protected]>
|
Code coverage report is ready! 📈
|
std::string.reserve(capacity) Effects: After reserve(), capacity() is greater or equal to the argument of reserve. C++ International Standard 2014 (N3797) 21.4.4 basic_string capacity
|
Code coverage report is ready! 📈
|
PLeVasseur
approved these changes
Jun 7, 2025
There was a problem hiding this comment.
Couple of suggestions, otherwise looks good. Thanks @pkleymonov-qnx!
Let's wait on eclipse-uprotocol/up-conan-recipes#36 merging and then merge this one 👍
Fix some links to QNX build instructions.
|
Code coverage report is ready! 📈
|
|
Thank you @pkleymonov-qnx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides changes for QNX 7.1/8.0 running on aarch64le/x86_64
issue: #314
NOTE: QNX cross-compilation are only supported from a Linux(x86_64) build machine.
Before building up-cpp we need to build all dependencies from up-conan-recipes:
Please follow instruction for QNX build in file up-conan-recipes/README.md
Pre-requisite:
Build up-cpp for QNX
closes #314