-
Notifications
You must be signed in to change notification settings - Fork 31
add support for QNX 7.1/8.0 #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix path for build artifacts
fix path for build artifacts
Code coverage report is ready! 📈
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pkleymonov-qnx for the contribution!
Could you open an issue for adding tests for building for QNX in CI as well?
fix whitespace Co-authored-by: Pete LeVasseur <[email protected]>
Code coverage report is ready! 📈
|
std::string.reserve(capacity) Effects: After reserve(), capacity() is greater or equal to the argument of reserve. C++ International Standard 2014 (N3797) 21.4.4 basic_string capacity
Code coverage report is ready! 📈
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of suggestions, otherwise looks good. Thanks @pkleymonov-qnx!
Let's wait on eclipse-uprotocol/up-conan-recipes#36 merging and then merge this one 👍
Fix some links to QNX build instructions.
Code coverage report is ready! 📈
|
Thank you @pkleymonov-qnx! |
This PR provides changes for QNX 7.1/8.0 running on aarch64le/x86_64
issue: #314
NOTE: QNX cross-compilation are only supported from a Linux(x86_64) build machine.
Before building up-cpp we need to build all dependencies from up-conan-recipes:
Please follow instruction for QNX build in file up-conan-recipes/README.md
Pre-requisite:
Build up-cpp for QNX
closes #314