Add L-2 communication - #27
Open
dddj698 wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Rebase and Merge after #26 |
|
Code coverage report is ready! 📈
|
stevenhartley
requested changes
Jul 17, 2024
stevenhartley
left a comment
stevenhartley
left a comment
There was a problem hiding this comment.
Small issue in the InMemorySubscriber only
There was a problem hiding this comment.
I have moved this to L3 folder for USubscription service client implementation, you might want to do the same after this is merged
Contributor
Author
There was a problem hiding this comment.
will do in following PR
| * @param options The call options for the subscription. | ||
| * @return Returns [UStatus] with the result from the unsubscribe request. | ||
| */ | ||
| override suspend fun unsubscribe( |
There was a problem hiding this comment.
You're not removing the SubscriptionChangeHandler that might have been registered in the subscribe() API
Contributor
Author
There was a problem hiding this comment.
it is removed in line 135 if invokeMethod success
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add L-2 communication with Examples.