Skip to content

Simplify uSubscription::Reset operation #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnotherDaniel merged 2 commits into from
Feb 17, 2026
Merged

Simplify uSubscription::Reset operation #322

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aac9e1f
Remove Reset.before parameter, correct spec text.
AnotherDaniel Feb 17, 2026
08e9f00
Fix: should deprecate parameters instead of removing them
AnotherDaniel Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions up-core-api/uprotocol/core/usubscription/v3/usubscription.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,10 +336,6 @@ message ResetRequest {
// Reason for the reset
optional Reason reason = 1;

// Reset all subscriptions that are before this time, if omitted, the
// current time is assumed
optional google.protobuf.Timestamp before = 2;

Comment thread
AnotherDaniel marked this conversation as resolved.
// The reason for triggering a reset, this is an optional attribute used
// to provide insight as to why a reset occurred
// More reasons will be added as we distill the business logic
Expand Down
2 changes: 1 addition & 1 deletion up-l3/usubscription/v3/README.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ Subscribe (and unsubscribe) to remote topics are handled by RPC calls between uS
[#reset-operation]
== Reset

This is a private API, to be used only between uSubscription services. Regular uEntities can call Unsubscribe() to flush their own subscriptions.
This is a private API, to be used only between uSubscription services.
Comment thread
sophokles73 marked this conversation as resolved.

[.specitem,oft-sid="dsn~usubscription-reset-protobuf~1",oft-needs="impl,utest"]
****
Expand Down