Skip to content

Update with up-transport-vsomeip-rust build changes #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 4, 2025

Conversation

PLeVasseur
Copy link
Contributor

No description provided.

Copy link

@dmacattack dmacattack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do the READMEs need updating ?

@PLeVasseur
Copy link
Contributor Author

do the READMEs need updating ?

Probably 🧐

@PLeVasseur PLeVasseur force-pushed the feature/update-to-new-vsomeip-build-style branch from 4e48ea0 to 69ef640 Compare March 3, 2025 18:23
@PLeVasseur PLeVasseur force-pushed the feature/update-to-new-vsomeip-build-style branch from 69ef640 to 3c6cd5d Compare March 3, 2025 18:26
@PLeVasseur PLeVasseur force-pushed the feature/update-to-new-vsomeip-build-style branch from 3fe3b8e to b2ef2c3 Compare March 3, 2025 18:41
@PLeVasseur PLeVasseur marked this pull request as ready for review March 3, 2025 18:55
@PLeVasseur PLeVasseur changed the title Test CI works with up-transport-vsomeip-rust build changes Update with up-transport-vsomeip-rust build changes Mar 3, 2025
@PLeVasseur PLeVasseur requested a review from ValMobBIllich March 3, 2025 18:56
@PLeVasseur
Copy link
Contributor Author

Hey @ValMobBIllich -- can you take a look? As you were saying, if we get this merged and you rebase on it, then it's likely that #61 builds.

@BenediktIllich
Copy link

I feel like the env setup would possibly be more compact as a xtask program but I havent looked into those in a while... hard to read through that much bash for me :)

The fundamental change is just that the location of the cpp compiler is now dynamically determined which I guess is more stable?

@PLeVasseur
Copy link
Contributor Author

The fundamental change is just that the location of the cpp compiler is now dynamically determined which I guess is more stable?

Exactly, it will be automatically determined for you by running envsetup.sh. It's already "proven in use" over in up-transport-vsomeip-rust with the same over there.

I feel like the env setup would possibly be more compact as a xtask program but I havent looked into those in a while... hard to read through that much bash for me :)

Yeah, possibly! I'm open to submissions for the like in a follow-up.

@PLeVasseur PLeVasseur requested a review from dmacattack March 4, 2025 13:57
@dmacattack
Copy link

Yeah, possibly! I'm open to submissions for the like in a follow-up.

Ditto. Envsetup idea stems from build systems like buildroot, yocto, openWRT, etc. bash is pretty much guaranteed to exist on the runner than anything else, and adds flexibility if the project isn't rust.

Copy link

@dmacattack dmacattack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@PLeVasseur PLeVasseur merged commit 9a8d277 into main Mar 4, 2025
10 checks passed
@PLeVasseur PLeVasseur deleted the feature/update-to-new-vsomeip-build-style branch March 4, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants