Initial commit for up-subscribe-rust #1
Conversation
There was a problem hiding this comment.
Hey @AnotherDaniel -- leaving some initial comments. Will need to go through for one or more additional passes 🙂
|
|
||
| /// This trait (and the comprised UTransportHolder trait) is simply there to have a generic type that | ||
| /// usubscription Listeners deal with, so that USubscriptionService can be properly mocked. | ||
| pub trait USubscriptionServiceAbstract: |
There was a problem hiding this comment.
Question on this. To implement any of the listeners, I had to pass in a "USubscriptionServiceAbstract" instead of a USubscriptionService. That was awkward, because I ended up having to add this line to usubscription.rs
// implement SubscriptionServiceAbstract
impl USubscriptionServiceAbstract for USubscriptionService {}
Is there a way for those listeners to take in the real service instead of abstract service?
There was a problem hiding this comment.
I am not 100% happy with the -Abstract thing myself, tbh - on the other hand, this is the best overall way I found so far to avoid having to deal with UTransport handles all over the place, while at the same time making all the mocks etc work properly.
Let's agree to keep this one on the radar? I do expect some changes in this area anyways, when I'm picking up all the new base L2 implementations from up-rust...
This is an initial commit for the Rust implementation of USubscription. Heavily work-in-progress, many todos already known (refer to README.md) and yet unknown.