Skip to content

Add capability to persist subscription expiry property #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AnotherDaniel
Copy link
Contributor

In preparation for implementing subscription expiry, add capability to receive and persist subscription expiry information.

@AnotherDaniel AnotherDaniel marked this pull request as draft May 15, 2025 15:22
@AnotherDaniel AnotherDaniel requested a review from sophokles73 May 16, 2025 12:35
@AnotherDaniel AnotherDaniel self-assigned this May 16, 2025
@AnotherDaniel AnotherDaniel added the enhancement New feature or request label May 16, 2025
@AnotherDaniel AnotherDaniel marked this pull request as ready for review May 16, 2025 12:35
Copy link

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you already added logic to automatically terminate a subscription when it has expired? I couldn't find that part ...

@AnotherDaniel
Copy link
Contributor Author

No, not yet - this is a first step which only takes care of adding awareness of the expiration property to internal APIs and persistency.

Copy link

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnotherDaniel AnotherDaniel force-pushed the subscription_expiry branch from bbf6034 to 0f32b51 Compare May 19, 2025 07:18
@AnotherDaniel AnotherDaniel merged commit 5adff7e into eclipse-uprotocol:main May 19, 2025
11 checks passed
@AnotherDaniel AnotherDaniel deleted the subscription_expiry branch May 19, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants