Skip to content

Conversation

AnotherDaniel
Copy link
Contributor

@AnotherDaniel AnotherDaniel commented Jul 24, 2025

The Reset() operation defined by the usubscription spec was missing entirely so far, this change implements that, plus any adjacent required changes and functionality.

Implements:

  • dsn~usubscription-reset-protobuf~1
  • req~usubscription-reset~1
  • req~usubscription-reset-only-usubscription~1

@AnotherDaniel AnotherDaniel self-assigned this Jul 24, 2025
@AnotherDaniel AnotherDaniel added the enhancement New feature or request label Jul 24, 2025
Copy link

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if I understand the use case. Is the up-subscription-cli supposed to be used for interacting with a uSubscription service running as a separate process? If so, then using LocalTransport will not work because it can only be used for communication within the same process, i.e. it does not support remote invocation of services across process boundaries ...

@AnotherDaniel
Copy link
Contributor Author

AnotherDaniel commented Jul 25, 2025

No, the cli is simply a configuration frontend for running up-subscription service. It sets up up-transports according to configuration, then hands them over to up-susbcription to use.

Also at the moment, the local transport is the only thing that can be made to compile, until mqtt5 and zenoh up-transports are made available to use the latest up-rust revision (that includes the reset() changes that were done to accommodate this PR here).

Copy link

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnotherDaniel AnotherDaniel force-pushed the req_usubscription-reset branch from bc2c8df to fcff1b5 Compare August 4, 2025 13:38
@AnotherDaniel AnotherDaniel merged commit 4c1b98a into eclipse-uprotocol:main Aug 4, 2025
11 checks passed
@AnotherDaniel AnotherDaniel deleted the req_usubscription-reset branch August 4, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants