Skip to content

Update to latest up-spec release, fix breakage, bump versions#31

Merged
AnotherDaniel merged 2 commits intoeclipse-uprotocol:mainfrom
etas-contrib:up-spec-update
Dec 18, 2025
Merged

Update to latest up-spec release, fix breakage, bump versions#31
AnotherDaniel merged 2 commits intoeclipse-uprotocol:mainfrom
etas-contrib:up-spec-update

Conversation

@AnotherDaniel
Copy link
Contributor

Main breakage caused by:

  • authority names using upper case letters
  • soure UUri resource ID not being 0

@AnotherDaniel AnotherDaniel self-assigned this Dec 12, 2025
Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason why you need to implement the LocalUriProvider trait manually?

@AnotherDaniel
Copy link
Contributor Author

Is there a particular reason why you need to implement the LocalUriProvider trait manually?

Uh no, other than "it was always done this way" - what is the current alternative?

@sophokles73
Copy link
Contributor

Is there a particular reason why you need to implement the LocalUriProvider trait manually?

Uh no, other than "it was always done this way" - what is the current alternative?

Simply use StaticUriProvider ...

@AnotherDaniel
Copy link
Contributor Author

Is there a particular reason why you need to implement the LocalUriProvider trait manually?

Uh no, other than "it was always done this way" - what is the current alternative?

Simply use StaticUriProvider ...

Hm - yes in principle. But that doesn't implement Clone (and Debug), which means changing the code to use it will result in a larger changeset that I'd like to keep out of this PR.

@eclipse-uprotocol eclipse-uprotocol deleted a comment from sophokles73 Dec 17, 2025
Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnotherDaniel AnotherDaniel merged commit d8f2460 into eclipse-uprotocol:main Dec 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants