updated signature and up-cpp version#115
Open
MaximilianToe wants to merge 1 commit into
Open
Conversation
Contributor
|
So somewhat unsurprisingly up-tck is failing the build here. Likely not related to your changes. It's been not updated in about seven months. The meeting next week about up-tck can help us rescope to something: 1. valuable and 2. maintainable. |
MaximilianToe
force-pushed
the
update_signature_and_version
branch
from
ae0dbea to
c2dec86
Compare
Contributor
|
Let's hold on this one, as we discussed up-zenoh-example-cpp will be updated to remove the socket transport in favor of using Zenoh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the signature of cleanupListener. It furthermore updated the version of up-cpp after this change to make it compatible with other projects.
Closes #114