send, register_listener, and unregister_listener#78
Conversation
|
A short summary of these changes now exists in the PR description |
Co-authored-by: kwarraich <kwarraic@andrew.cmu.edu> Co-authored-by: Noella Horo <nhoro@andrew.cmu.edu> Co-authored-by: vidishac2004 <144144085+vidishac2004@users.noreply.github.com> Co-authored-by: arakabCL <arakab@andrew.cmu.edu>
559d728 to
f0ccb58
Compare
|
I forgot to add the students as co-authors on the original commit 😭. Looking into how to fix this
I would like their co-authoring to be part of the original commit of this PR. That way their contribution is correctly reflected if people ever search for what exact code they helped contribute. Therefore, I amended the commit for this PR and added them as coauthors to it, and force pushed it. Sorry 😄 this will cause |
|
I only saw 4 students just looking through their PRs commit history. Let me know if you know of anyone I missed. Here's their info Co-authored-by: kwarraich kwarraic@andrew.cmu.edu |
|
So, |
|
FYI I have rewritten the PR description based on my changes for iceoryx2 0.7.0 |
added publisher example !!! now there is a segmentation fault when the subscriber receives a published message. yay, a new error
PLeVasseur
left a comment
There was a problem hiding this comment.
Hey @Xerner -- this looks good.
As we chatted about, there's some extensions we'd need to make in up-rust to support true zero-copy.
PLeVasseur
left a comment
There was a problem hiding this comment.
Hey @Xerner -- this looks like a great start.
We'll need to make some extensions to up-rust to support true zero-copy in the case of using Eclipse iceoryx2 as we talked a bit about.



Summary of Changes (iceoryx2 0.7.0)
FixedSizeVecServiceNameinstancesUTransporttrait functions now interact with iceoryx2 classes directly in their async fn definitions inIceoryx2PubSubUListenerUListenerUMessageUUritoServiceNamefunctions that handles convertingUUri's into Iceoryx2ServiceNameinstances. This was almost a 1-1 copy from what was in the students PRs. All I did was update their code to use uProtocolsUMessageTypeand rely on what the expected iceoryx2MessagingPatternwill be. ❗I think it's still somewhat unfinished. Let me know if I need to put more work into it before this is good enough to mergeapt-getcould not find java SDK version 17 anymore and I was not sure whyRelated Project Issues
send()ofUTransporttrait #11register_listener()ofUTransporttrait #12unregister_listener()ofUTransporttrait #13examples/folder for a publisher ofPublish-style messages #19examples/folder for a subscriber toPublish-style messages #20