Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yarl instead of grpcio in tests to avoid dependabot warnings #37

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

erikbosch
Copy link
Contributor

@erikbosch erikbosch commented Aug 2, 2024

Background is that there is quite often known vulnerabilities for grpcio. We do not want to disable dependabot for this repository but on the other hand we do not want to spend time updating testcases, and dependabot has as of today no good mechanism to exclude directories. So then the question comes - could we use some other (more stable) package in the test cases to avoid future dependabot issues.

Also fixing some NOTICE file regressions on main

@erikbosch erikbosch force-pushed the erik-dep branch 4 times, most recently from 39e8655 to af2c365 Compare August 2, 2024 08:37
@erikbosch erikbosch marked this pull request as ready for review August 2, 2024 08:50
Copy link
Contributor

@dennismeister93 dennismeister93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me to have more reliant test cases - doesn't hurt to use another library!

@erikbosch erikbosch merged commit 6b0d153 into eclipse-velocitas:main Aug 2, 2024
4 checks passed
@erikbosch erikbosch deleted the erik-dep branch August 2, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants