Skip to content

Conversation

@BjoernAtBosch
Copy link
Member

No description provided.

Copy link
Contributor

@MP91 MP91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this PR really needed currently? If conan is anyhow not working there is no change to the behavior before or?

@BjoernAtBosch
Copy link
Member Author

BjoernAtBosch commented May 8, 2025

is this PR really needed currently? If conan is anyhow not working there is no change to the behavior before or?

Conan 2 support of Pivotal License Finder has a bug resulting in an endless loop while scanning a directory containing a conanfile. I've extended the description in the readme regarding the issue.

So, therefore this PR is mandatory.

Copy link
Contributor

@MP91 MP91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BjoernAtBosch BjoernAtBosch merged commit fcffb1b into main May 9, 2025
6 checks passed
@BjoernAtBosch BjoernAtBosch deleted the bjoern_conan2 branch May 9, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants